Fixed wrong full refresh

src/myfasthtml/controls/Profiler.py

@@ -145,7 +145,7 @@ class Commands(BaseCommands):
       self._owner,
       self._owner.handle_select_trace,
       kwargs={"trace_id": trace_id},
-    ).htmx(target=f"#{self._id}")
+    ).htmx(target=f"#tr_{trace_id}")
 
 
 class Profiler(SingleInstance):
@@ -186,8 +186,17 @@ class Profiler(SingleInstance):
   
   def handle_select_trace(self, trace_id: str):
     """Select a trace row and re-render to show it highlighted."""
+    if self._selected_id is not None:
+      old_trace = next(trace for trace in profiler.traces if trace.trace_id == self._selected_id)
+    else:
+      old_trace = None
+    
     self._selected_id = trace_id
-    return self
+    trace = next(trace for trace in profiler.traces if trace.trace_id == trace_id)
+    
+    return (self._mk_trace_item(trace),
+            self._mk_trace_item(old_trace),
+            self._panel.set_right(self._mk_right_panel(trace)))
   
   def handle_toggle_detail_view(self):
     """Toggle detail panel between tree and pie view."""
@@ -245,32 +254,36 @@ class Profiler(SingleInstance):
       id=f"tb_{self._id}",
     )
   
+  def _mk_trace_item(self, trace: ProfilingTrace):
+    if trace is None:
+      return None
+    
+    ts = trace.timestamp.strftime("%H:%M:%S.") + f"{trace.timestamp.microsecond // 1000:03d}"
+    duration_cls = self._duration_cls(trace.total_duration_ms)
+    row_cls = "mf-profiler-row mf-profiler-row-selected" if trace.trace_id == self._selected_id else "mf-profiler-row"
+    
+    return mk.mk(
+      Div(
+        Div(
+          Span(trace.command_name, cls="mf-profiler-cmd"),
+          Span(trace.command_description, cls="mf-profiler-cmd-description"),
+          cls="mf-profiler-cmd-cell",
+        ),
+        Span(f"{trace.total_duration_ms:.1f} ms", cls=f"mf-profiler-duration {duration_cls}"),
+        Span(ts, cls="mf-profiler-ts"),
+        cls=row_cls,
+        id=f"tr_{trace.trace_id}",
+      ),
+      command=self.commands.select_trace(trace.trace_id),
+    )
+  
   def _mk_trace_list(self):
     """Build the trace list with one clickable row per recorded trace."""
     traces = profiler.traces
     if not traces:
       return Div("No traces recorded.", cls="mf-profiler-empty")
     
-    rows = []
+    rows = [self._mk_trace_item(trace) for trace in reversed(traces)]
-    for trace in reversed(traces):
-      ts = trace.timestamp.strftime("%H:%M:%S.") + f"{trace.timestamp.microsecond // 1000:03d}"
-      duration_cls = self._duration_cls(trace.total_duration_ms)
-      row_cls = "mf-profiler-row mf-profiler-row-selected" if trace.trace_id == self._selected_id else "mf-profiler-row"
-
-      row = mk.mk(
-        Div(
-          Div(
-            Span(trace.command_name, cls="mf-profiler-cmd"),
-            Span(trace.command_description, cls="mf-profiler-cmd-description"),
-            cls="mf-profiler-cmd-cell",
-          ),
-          Span(f"{trace.total_duration_ms:.1f} ms", cls=f"mf-profiler-duration {duration_cls}"),
-          Span(ts, cls="mf-profiler-ts"),
-          cls=row_cls,
-        ),
-        command=self.commands.select_trace(trace.trace_id),
-      )
-      rows.append(row)
     
     return Div(
       Div(
@@ -305,8 +318,10 @@ class Profiler(SingleInstance):
     tree_cls = "mf-profiler-view-btn mf-profiler-view-btn-active" if self._detail_view == "tree" else "mf-profiler-view-btn"
     pie_cls = "mf-profiler-view-btn mf-profiler-view-btn-active" if self._detail_view == "pie" else "mf-profiler-view-btn"
     toggle = Div(
-      mk.icon(text_bullet_list_tree20_filled, command=self.commands.toggle_detail_view(), tooltip="Span tree", cls=tree_cls),
+      mk.icon(text_bullet_list_tree20_filled, command=self.commands.toggle_detail_view(), tooltip="Span tree",
-      mk.icon(data_pie24_regular, command=self.commands.toggle_detail_view(), tooltip="Pie chart (coming soon)", cls=pie_cls),
+              cls=tree_cls),
+      mk.icon(data_pie24_regular, command=self.commands.toggle_detail_view(), tooltip="Pie chart (coming soon)",
+              cls=pie_cls),
       cls="mf-profiler-view-toggle",
     )
     return Div(title, toggle, cls="mf-profiler-detail-header")
@@ -327,10 +342,10 @@ class Profiler(SingleInstance):
       conf=PropertiesConf(
         obj=trace,
         groups={"Metadata": {
-          "command": "command_name",
+            "command": "command_name",
-          "description": "command_description",
+            "description": "command_description",
-          "duration_ms": "total_duration_ms",
+            "duration_ms": "total_duration_ms",
-          "timestamp": "timestamp",
+            "timestamp": "timestamp",
         }},
       ),
       _id="-detail-meta",
@@ -376,6 +391,14 @@ class Profiler(SingleInstance):
       cls="mf-profiler-detail",
     )
   
+  def _mk_right_panel(self, trace: "ProfilingTrace"):
+    """Build the right panel with a trace detail view."""
+    return (
+        self._mk_detail_panel(trace)
+        if trace is not None
+        else self._mk_detail_placeholder()
+    )
+  
   # ------------------------------------------------------------------
   # Render
   # ------------------------------------------------------------------
@@ -387,14 +410,8 @@ class Profiler(SingleInstance):
         (t for t in profiler.traces if t.trace_id == self._selected_id), None
       )
     
-    right_panel = (
-      self._mk_detail_panel(selected_trace)
-      if selected_trace is not None
-      else self._mk_detail_placeholder()
-    )
-
     self._panel.set_main(self._mk_trace_list())
-    self._panel.set_right(right_panel)
+    self._panel.set_right(self._mk_right_panel(selected_trace))
     return Div(
       self._mk_toolbar(),
       self._panel,