Improving completion to support the correct table name for autocompletion and formatting

src/myfasthtml/core/dsl/base_completion.py

@@ -33,6 +33,7 @@ class BaseCompletionEngine(ABC):
         provider: Metadata provider for context-aware suggestions
     """
     self.provider = provider
+    self._id = type(self).__name__
   
   def get_completions(self, text: str, cursor: Position) -> CompletionResult:
     """
@@ -169,4 +170,4 @@ class BaseCompletionEngine(ABC):
     )
   
   def get_id(self):
-    return type(self).__name__
+    return self._id

src/myfasthtml/core/dsl/base_provider.py

@@ -19,7 +19,7 @@ class BaseMetadataProvider(Protocol):
   can extend this with additional methods.
   """
   
-  def get_style_presets(self) -> list[str]:
+  def list_style_presets(self) -> list[str]:
     """
     Return the list of available style preset names.
 
@@ -28,7 +28,7 @@ class BaseMetadataProvider(Protocol):
     """
     ...
   
-  def get_format_presets(self) -> list[str]:
+  def list_format_presets(self) -> list[str]:
     """
     Return the list of available format preset names.
 

src/myfasthtml/core/dsls.py

@@ -14,9 +14,9 @@ class DslsManager:
   dsls: dict[str, DslDefinition] = {}
   
   @staticmethod
-  def register(dsl_id: str, completion: BaseCompletionEngine, validation: DSLParser):
+  def register(completion: BaseCompletionEngine, validation: DSLParser):
     # then engine_id is actually the DSL id
-    DslsManager.dsls[dsl_id] = DslDefinition(completion, validation)
+    DslsManager.dsls[completion.get_id()] = DslDefinition(completion, validation)
   
   @staticmethod
   def get_completion_engine(engine_id) -> BaseCompletionEngine:

src/myfasthtml/core/formatting/dsl/completion/FormattingCompletionEngine.py

@@ -3,8 +3,10 @@ Completion engine for the formatting DSL.
 
 Implements the BaseCompletionEngine for DataGrid formatting rules.
 """
+
 from myfasthtml.core.dsl.base_completion import BaseCompletionEngine
 from myfasthtml.core.dsl.types import Position, Suggestion, CompletionResult
+from myfasthtml.core.utils import make_safe_id
 from . import suggestions as suggestions_module
 from .contexts import Context, DetectedScope, detect_scope, detect_context
 from .provider import DatagridMetadataProvider
@@ -21,7 +23,7 @@ class FormattingCompletionEngine(BaseCompletionEngine):
   - Conditions with operators and values
   """
   
-  def __init__(self, provider: DatagridMetadataProvider):
+  def __init__(self, provider: DatagridMetadataProvider, table_name: str):
     """
     Initialize the completion engine.
 
@@ -30,6 +32,8 @@ class FormattingCompletionEngine(BaseCompletionEngine):
     """
     super().__init__(provider)
     self.provider: DatagridMetadataProvider = provider
+    self.table_name: str = table_name  # current table name
+    self._id = "formatting_completion_engine#" + make_safe_id(table_name)
   
   def detect_scope(self, text: str, current_line: int) -> DetectedScope:
     """

src/myfasthtml/core/formatting/dsl/completion/provider.py

@@ -5,10 +5,12 @@ Provides access to DataGrid metadata (columns, values, row counts)
 for context-aware autocompletion.
 """
 
-from typing import Protocol, Any
+from typing import Any
+
+from myfasthtml.core.dsl.base_provider import BaseMetadataProvider
 
 
-class DatagridMetadataProvider(Protocol):
+class DatagridMetadataProvider(BaseMetadataProvider):
   """
   Protocol for providing DataGrid metadata to the autocompletion engine.
 
@@ -70,25 +72,3 @@ class DatagridMetadataProvider(Protocol):
         Number of rows
     """
     ...
-  
-  def list_style_presets(self) -> list[str]:
-    """
-    Return the list of available style preset names.
-
-    Includes default presets (primary, error, etc.) and custom presets.
-
-    Returns:
-        List of style preset names
-    """
-    ...
-  
-  def list_format_presets(self) -> list[str]:
-    """
-    Return the list of available format preset names.
-
-    Includes default presets (EUR, USD, etc.) and custom presets.
-
-    Returns:
-        List of format preset names
-    """
-    ...

src/myfasthtml/core/utils.py

@@ -375,7 +375,7 @@ def post(session, b_id: str, values: dict):
   :param values:
   :return:
   """
-  logger.debug(f"Entering {Routes.Bindings} with {session=}, {b_id=}, {values=}")
+  logger.debug(f"Entering {Routes.Bindings} with session='{debug_session(session)}', {b_id=}, {values=}")
   from myfasthtml.core.bindings import BindingsManager
   binding = BindingsManager.get_binding(b_id)
   if binding:
@@ -396,7 +396,8 @@ def get(session, e_id: str, text: str, line: int, ch: int):
   :param ch:
   :return:
   """
-  logger.debug(f"Entering {Routes.Completions} with {session=}, {e_id=}, {text=}, {line=}, {ch}")
+  logger.debug(
+    f"Entering {Routes.Completions} with session='{debug_session(session)}', {e_id=}, text={len(text)} char(s), {line=}, {ch=}")
   completion = DslsManager.get_completion_engine(e_id)
   result = completion.get_completions(text, Position(line, ch))
   return result.to_dict()
@@ -413,7 +414,8 @@ def get(session, e_id: str, text: str, line: int, ch: int):
   :param ch:
   :return:
   """
-  logger.debug(f"Entering {Routes.Validations} with {session=}, {e_id=}, {text=}, {line=}, {ch}")
+  logger.debug(
+    f"Entering {Routes.Validations} with session='{debug_session(session)}', {e_id=}, text={len(text)} char(s), {line=}, {ch=}")
   validation = DslsManager.get_validation_parser(e_id)
   try:
     validation.parse(text)