Fixed bug when evaluating numbers several times

tests/core/test_SheerkaSetsManager.py

@@ -260,21 +260,6 @@ class TestSheerkaSetsManager(TestUsingMemoryBasedSheerka):
         assert sheerka.isa(sheerka.new("one"), number)  # sanity
         assert not sheerka.isa(another_one, number)  # Correct this misbehaviour when BuiltinConcepts.IS is implemented
 
-    def test_concept_expression_recurse_id_is_updated(self):
-        sheerka, context, one, number, twenties = self.init_concepts(
-            "one",
-            "number",
-            Concept("twenties", definition="'twenty' number").def_var("number"),
-            create_new=True
-        )
-
-        assert twenties.get_bnf().elements[1].recurse_id is None
-
-        # update number
-        sheerka.set_isa(context, sheerka.new("one"), number)
-
-        assert twenties.get_bnf().elements[1].recurse_id == "1003#1002(number)"
-
     def test_concepts_in_group_cache_is_updated(self):
         sheerka, context, one, two, number = self.init_concepts("one", "two", "number")
 
@@ -286,6 +271,9 @@ class TestSheerkaSetsManager(TestUsingMemoryBasedSheerka):
         concepts_in_cache = sheerka.cache_manager.get(SheerkaSetsManager.CONCEPTS_IN_GROUPS_ENTRY, number.id)
         assert [c.id for c in concepts_in_cache] == [one.id]
 
+        # pretend that number has been updated in sheerka.concepts_grammar
+        sheerka.concepts_grammars.put(number.id, "some parsing expression with 'one' only")
+
         # add another element to number
         sheerka.set_isa(context, sheerka.new("two"), number)
         elements = sheerka.get_set_elements(context, number)
@@ -294,6 +282,9 @@ class TestSheerkaSetsManager(TestUsingMemoryBasedSheerka):
         concepts_in_cache = sheerka.cache_manager.get(SheerkaSetsManager.CONCEPTS_IN_GROUPS_ENTRY, number.id)
         assert {c.id for c in concepts_in_cache} == {one.id, two.id}
 
+        # make sure the bnf definition is also updated
+        assert number.id not in sheerka.concepts_grammars
+
 
 class TestSheerkaSetsManagerUsingFileBasedSheerka(TestUsingFileBasedSheerka):
     def test_i_can_add_concept_to_set_and_retrieve_it_in_another_session(self):