Added chicken and egg recursion detection

tests/core/test_SheerkaCreateNewConcept.py

@@ -1,5 +1,5 @@
 from core.builtin_concepts import BuiltinConcepts
-from core.concept import PROPERTIES_TO_SERIALIZE
+from core.concept import PROPERTIES_TO_SERIALIZE, Concept
 from sdp.sheerkaDataProvider import SheerkaDataProvider
 
 from tests.TestUsingMemoryBasedSheerka import TestUsingMemoryBasedSheerka
@@ -80,12 +80,10 @@ class TestSheerkaCreateNewConcept(TestUsingMemoryBasedSheerka):
         sheerka.cache_by_key = {}  # reset the cache
         loaded = sheerka.get(concept.key)
 
-        assert loaded is not None
         assert loaded == concept
 
         # I can also get it by its id
         loaded = sheerka.sdp.get(sheerka.CONCEPTS_BY_ID_ENTRY, concept.id)
-        assert loaded is not None
         assert loaded == concept
 
     def test_i_can_get_a_concept_by_its_id(self):
@@ -96,7 +94,6 @@ class TestSheerkaCreateNewConcept(TestUsingMemoryBasedSheerka):
         sheerka.cache_by_key = {}  # reset the cache
         loaded = sheerka.get_by_id(concept.id)
 
-        assert loaded is not None
         assert loaded == concept
 
     def test_i_can_get_list_of_concept_when_same_key_when_no_cache(self):
@@ -178,3 +175,12 @@ class TestSheerkaCreateNewConcept(TestUsingMemoryBasedSheerka):
 
         result = sheerka.get(concept1.key, "wrong id")
         assert sheerka.isinstance(result, BuiltinConcepts.UNKNOWN_CONCEPT)
+
+    def test_concept_that_references_itself_is_correctly_created(self):
+        sheerka = self.get_sheerka()
+        concept = Concept("foo", body="foo")
+
+        res = sheerka.create_new_concept(self.get_context(sheerka), concept)
+
+        assert res.status
+