Added ModifyConcept function, and fixed 'isa' not working

tests/core/test_SheerkaCreateNewConcept.py

@@ -1,5 +1,6 @@
 from core.builtin_concepts import BuiltinConcepts
 from core.concept import PROPERTIES_TO_SERIALIZE, Concept
+from core.sheerka.Sheerka import Sheerka
 from sdp.sheerkaDataProvider import SheerkaDataProvider
 
 from tests.TestUsingMemoryBasedSheerka import TestUsingMemoryBasedSheerka
@@ -25,7 +26,10 @@ class TestSheerkaCreateNewConcept(TestUsingMemoryBasedSheerka):
         assert concept.key in sheerka.cache_by_key
         assert concept.id in sheerka.cache_by_id
         assert sheerka.sdp.io.exists(
-            sheerka.sdp.io.get_obj_path(SheerkaDataProvider.ObjectsFolder, concept_found.get_digest()))
+            sheerka.sdp.io.get_obj_path(SheerkaDataProvider.ObjectsFolder, concept_found.get_origin()))
+        assert sheerka.sdp.exists(Sheerka.CONCEPTS_BY_HASH_ENTRY, concept.get_definition_hash())
+        assert sheerka.sdp.exists(Sheerka.CONCEPTS_BY_ID_ENTRY, concept.id)
+        assert sheerka.sdp.exists(Sheerka.CONCEPTS_ENTRY, concept.key)
 
     def test_i_cannot_add_the_same_concept_twice(self):
         """
@@ -77,7 +81,7 @@ class TestSheerkaCreateNewConcept(TestUsingMemoryBasedSheerka):
         concept = self.get_default_concept()
         sheerka.create_new_concept(self.get_context(sheerka), concept)
 
-        sheerka.cache_by_key = {}  # reset the cache
+        sheerka.reset_cache()
         loaded = sheerka.get(concept.key)
 
         assert loaded == concept
@@ -86,6 +90,16 @@ class TestSheerkaCreateNewConcept(TestUsingMemoryBasedSheerka):
         loaded = sheerka.sdp.get(sheerka.CONCEPTS_BY_ID_ENTRY, concept.id)
         assert loaded == concept
 
+    def test_i_can_instantiate_a_concept_from_sdp(self):
+        sheerka = self.get_sheerka()
+        concept = Concept("foo")
+        sheerka.create_new_concept(self.get_context(sheerka), concept)
+
+        sheerka.reset_cache()
+        loaded = sheerka.new("foo")
+
+        assert loaded == concept
+
     def test_i_can_get_a_concept_by_its_id(self):
         sheerka = self.get_sheerka()
         concept = self.get_default_concept()
@@ -105,6 +119,8 @@ class TestSheerkaCreateNewConcept(TestUsingMemoryBasedSheerka):
         res1 = sheerka.create_new_concept(self.get_context(sheerka), concept1)
         res2 = sheerka.create_new_concept(self.get_context(sheerka), concept2)
 
+        assert res1.status
+        assert res2.status
         assert res1.value.body.key == res2.value.body.key  # same key
 
         sheerka.cache_by_key = {}  # reset the cache