Fixed #29: Parsers: Implement parsing memoization

Fixed #77 : Parser: ShortTermMemoryParser should be called separately
Fixed #78 : Remove VariableNode usage
Fixed #79 : ConceptManager: Implement compile caching
Fixed #80 : SheerkaExecute : parsers_key is not correctly computed
Fixed #81 : ValidateConceptEvaluator : Validate concept's where and pre clauses right after the parsing
Fixed #82 : SheerkaIsAManager: isa() failed when the set as a body
Fixed #83 : ValidateConceptEvaluator : Support BNF and SYA Concepts
Fixed #84 : ExpressionParser: Implement the parser as a standard parser
Fixed #85 : Services: Give order to services
Fixed #86 : cannot manage smart_get_attr(the short, color)

tests/core/test_SheerkaEvaluateRules.py

@@ -2,14 +2,14 @@ import operator
 
 import pytest
 
-from core.builtin_concepts_ids import BuiltinConcepts
 from core.concept import Concept, DEFINITION_TYPE_DEF
 from core.rule import Rule, ACTION_TYPE_EXEC
 from core.sheerka.Sheerka import RECOGNIZED_BY_ID, RECOGNIZED_BY_NAME
 from core.sheerka.services.SheerkaEvaluateRules import SheerkaEvaluateRules, LOW_PRIORITY_RULES, DISABLED_RULES
 from core.sheerka.services.SheerkaExecute import ParserInput
-from core.sheerka.services.SheerkaRuleManager import SheerkaRuleManager, CompiledCondition
+from core.sheerka.services.SheerkaRuleManager import SheerkaRuleManager, CompiledCondition, PythonConditionExprVisitor
 from evaluators.PythonEvaluator import PythonEvaluator
+from parsers.ExpressionParser import ExpressionParser
 from parsers.PythonParser import PythonParser
 from sheerkapython.python_wrapper import Expando
 from tests.TestUsingMemoryBasedSheerka import TestUsingMemoryBasedSheerka
@@ -40,7 +40,7 @@ class TestSheerkaEvaluateRules(TestUsingMemoryBasedSheerka):
             DISABLED_RULES: [r7]
         }
 
-    @pytest.mark.skip("Not ready for that")
+    @pytest.mark.skip("Rete is not ready for that")
     def test_i_can_evaluate_question_concept_rules(self):
         sheerka, context, concept, r1, r2, r3, r4, r5, r6, r7, r8, r9 = self.init_test().with_concepts(
             Concept("x equals y", body="x == y", pre="is_question()").def_var("x").def_var("y"),
@@ -152,7 +152,7 @@ class TestSheerkaEvaluateRules(TestUsingMemoryBasedSheerka):
 
         there_instance = sheerka.new_from_template(there, there.key)
         if recognized_by:
-            there_instance.set_hint(BuiltinConcepts.RECOGNIZED_BY, recognized_by)
+            there_instance.get_hints().recognized_by = recognized_by
         ret = sheerka.ret("evaluator", True, sheerka.new(greetings, a=there_instance))
         res = service.evaluate_rules(context, [rule], {"__ret": ret}, set())
         assert res == {True: [rule]}
@@ -175,7 +175,7 @@ class TestSheerkaEvaluateRules(TestUsingMemoryBasedSheerka):
 
         my_friend_instance = sheerka.new_from_template(my_friend, my_friend.key)
         if recognized_by:
-            my_friend_instance.set_hint(BuiltinConcepts.RECOGNIZED_BY, recognized_by)
+            my_friend_instance.get_hints().recognized_by = recognized_by
         ret = sheerka.ret("evaluator", True, sheerka.new(greetings, a=my_friend_instance))
         res = service.evaluate_rules(context, [rule], {"__ret": ret}, set())
         assert res == {True: [rule]}
@@ -211,7 +211,8 @@ class TestSheerkaEvaluateRules(TestUsingMemoryBasedSheerka):
     def test_i_can_evaluate_concept_rule_with_the_same_name_when_the_second_concept_is_declared_after(self):
         sheerka, context, g1, rule, g2 = self.init_test().with_concepts(
             Concept("greetings", definition="hello a", definition_type=DEFINITION_TYPE_DEF).def_var("a"),
-            create_new=True).with_format_rules(Rule(predicate="recognize(__ret.body, greetings)", action="")).with_concepts(
+            create_new=True).with_format_rules(
+            Rule(predicate="recognize(__ret.body, greetings)", action="")).with_concepts(
             Concept("greetings", definition="hi a", definition_type=DEFINITION_TYPE_DEF).def_var("a")).unpack()
 
         service = sheerka.services[SheerkaEvaluateRules.NAME]
@@ -249,3 +250,22 @@ class TestSheerkaEvaluateRules(TestUsingMemoryBasedSheerka):
 
         assert rule in evaluate_rule_service.network.rules
         assert rule.rete_net == evaluate_rule_service.network
+
+    def test_i_can_get_missing_variables_when_evaluate_conditions(self):
+        sheerka, context = self.init_test().unpack()
+
+        expression = "isinstance(a, int)"
+        parser = ExpressionParser()
+        ret_val = parser.parse(context, ParserInput(expression))
+        parsed = ret_val.body.body
+
+        visitor = PythonConditionExprVisitor(context)
+        conditions = visitor.get_conditions(parsed)
+
+        missing_vars = set()
+        service = sheerka.services[SheerkaEvaluateRules.NAME]
+        res = service.evaluate_conditions(context, conditions, {}, missing_vars)
+
+        assert res == []
+        assert missing_vars == {"a"}
+