Fixed #72 : Exception when get_results(id=10)

Fixed #74 : Keyword parameters are no longer recognized when a concept that redefines equality is created
Fixed #118 : RecursionError: maximum recursion depth exceeded
Fixed #119 : PreventCircularReferenceEvaluator
Fixed #121 : Plural are not updated when new elements are added
Fixed #123 : BaseCache : Values in cache can be evicted before being committed
Fixed #105 : TOO_MANY_ERROR is not the relevant error when results are filtered

tests/core/test_SheerkaEvaluateConcept.py

@@ -1,9 +1,8 @@
 import pytest
 
-from core.builtin_concepts import BuiltinConcepts, ReturnValueConcept, ParserResultConcept
-from core.concept import Concept, DoNotResolve, ConceptParts, InfiniteRecursionResolved, \
-    DEFINITION_TYPE_DEF
-from core.global_symbols import NotInit, NotFound
+from core.builtin_concepts import BuiltinConcepts, ParserResultConcept, ReturnValueConcept
+from core.concept import Concept, ConceptParts, DEFINITION_TYPE_DEF, DoNotResolve, InfiniteRecursionResolved
+from core.global_symbols import NotFound, NotInit
 from core.sheerka.services.SheerkaEvaluateConcept import EvaluationHints, SheerkaEvaluateConcept
 from core.sheerka.services.SheerkaExecute import ParserInput
 from core.sheerka.services.SheerkaMemory import SheerkaMemory
@@ -540,7 +539,8 @@ class TestSheerkaEvaluateConcept(TestUsingMemoryBasedSheerka):
         assert evaluated.body == NotInit
         assert not evaluated.get_hints().is_evaluated
 
-        evaluated = sheerka.evaluate_concept(context, foo_instance, hints=EvaluationHints(eval_body=True))  # evaluate the body this time
+        evaluated = sheerka.evaluate_concept(context, foo_instance,
+                                             hints=EvaluationHints(eval_body=True))  # evaluate the body this time
         assert isinstance(evaluated.body, bool) and evaluated.body
 
     def test_i_can_apply_intermediate_where_condition_using_python(self):
@@ -1105,3 +1105,24 @@ class TestSheerkaEvaluateConcept(TestUsingMemoryBasedSheerka):
 
         assert sheerka.isinstance(evaluated, foo)
         assert not foo.get_hints().is_evaluated
+
+    def test_dynamic_concepts_are_never_considered_as_evaluated(self):
+        sheerka, context, foo = self.init_concepts("foo")
+        i = 0
+
+        def get_new_id():
+            nonlocal i
+            i += 1
+            return i
+
+        dynamic_foo = sheerka.new_dynamic(foo, "test", body="get_new_id()")
+        context.add_to_short_term_memory("get_new_id", get_new_id)
+
+        evaluated = sheerka.evaluate_concept(context, dynamic_foo, hints=EvaluationHints(eval_body=True))
+        assert evaluated.key == dynamic_foo.key
+        assert evaluated.body == 1
+        assert not evaluated.get_hints().is_evaluated
+
+        evaluated = sheerka.evaluate_concept(context, dynamic_foo, hints=EvaluationHints(eval_body=True))
+        assert evaluated.body == 2
+        assert not evaluated.get_hints().is_evaluated